[Connection] Unify connection classes from sdk & execution #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brynn Yin <biyi@microsoft.com>
Signed-off-by: Brynn Yin <biyi@microsoft.com>
brynn-code
force-pushed
the
brynn/unify-connection-classes
branch
from
9767906
to
47bd8c4
Compare
Signed-off-by: Brynn Yin <biyi@microsoft.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Signed-off-by: Brynn Yin <biyi@microsoft.com>
brynn-code
force-pushed
the
brynn/unify-connection-classes
branch
3 times, most recently
from
f98ce4d
to
233e00a
Compare
Signed-off-by: Brynn Yin <biyi@microsoft.com>
brynn-code
force-pushed
the
brynn/unify-connection-classes
branch
from
233e00a
to
a3cee55
Compare
wangchao1230
previously approved these changes
Aug 25, 2023
lalala123123
previously approved these changes
Aug 25, 2023
Stephen1993
previously approved these changes
Aug 25, 2023
0mza987
previously approved these changes
Aug 25, 2023
chjinche
reviewed
Aug 25, 2023
chjinche
reviewed
Aug 25, 2023
chjinche
reviewed
Aug 25, 2023
Signed-off-by: Brynn Yin <biyi@microsoft.com>
brynn-code
dismissed stale reviews from 0mza987, Stephen1993, lalala123123, and wangchao1230
via
6ee808b
wangchao1230
approved these changes
Aug 28, 2023
chjinche
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify connection classes from promptflow.connections and promptflow.entity.connections (sdk).
asdict()in tools code will be changed todict(connection)as connection object is not dataclass instance anymore.CustomConnection(key1=val1, key2=val2)any more, user should useCustomConnection(configs={key1: val1}, secrets={key2: val2}).connection.key1will print a warning, we recommend usingconnection.secrets[key1]to avoid some key has same name with connection object itself, such asname.